Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make check warnings #20

Open
dlm opened this issue Aug 20, 2018 · 2 comments
Open

Fix make check warnings #20

dlm opened this issue Aug 20, 2018 · 2 comments
Assignees

Comments

@dlm
Copy link
Contributor

dlm commented Aug 20, 2018

From Personal email from @jisuk1

So it seems like CRAN doesn't want Makefile and misc in the submission. For the submission, I can manually exclude them and submit, but for later maybe it would be better to reorganize file structure something like
r-tda: top level

  • TDA: put all the things to be submitted there
  • Makefiles
  • misc

so that on the submission we can just build package from TDA directory and submit it to CRAN. How do you think?

@dlm
Copy link
Contributor Author

dlm commented Aug 20, 2018

Thank you for updating by hand for the release. I don't think we need to refactor the repo for future releases though. We can use the .Rbuildignore to tell the build command what files to ignore.

I can't test until we get the memory_fix brach merged, but, I will push a PR with a proposed fix (and if I can figure out how, add make check to the automated testing on travis.

@jkim82133
Copy link
Collaborator

I merged memory_fix branch, so could you check whether this will work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants