Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyWB2] Query param fl is ignored #8

Open
sebastian-nagel opened this issue Sep 26, 2019 · 1 comment
Open

[PyWB2] Query param fl is ignored #8

sebastian-nagel opened this issue Sep 26, 2019 · 1 comment
Assignees
Labels
bug pywb2 Upgrade to PyWB 2

Comments

@sebastian-nagel
Copy link

The query parameter to select the result fields (fl) is ignored by PyWB 2.3.0. As visible in the code it has been renamed from fl to fields with a fall-back for the old param name. But it does not work and furthermore causes the output param to be ignored:

> curl 'http://index-pywb2.commoncrawl.org/CC-MAIN-2019-35-index?url=commoncrawl.org&matchType=domain&fields=url&output=text&limit=1'
http://commoncrawl.org/

> curl 'http://index-pywb2.commoncrawl.org/CC-MAIN-2019-35-index?url=commoncrawl.org&matchType=domain&fl=url&output=text&limit=1'
{"urlkey": "org,commoncrawl)/", "timestamp": "20190818052150", "charset": "UTF-8", "languages": "eng", "url": "http://commoncrawl.org/", "status": "200", "mime": "text/html", "filename": "crawl-data/CC-MAIN-2019-35/segments/1566027313617.6/warc/CC-MAIN-20190818042813-20190818064813-00014.warc.gz", "digest": "FM7M2JDBADOQIHKCSFKVTAML4FL2HPHT", "offset": "42695747", "mime-detected": "text/html", "length": "5413", "source": "CC-MAIN-2019-35/indexes/cluster.idx", "source-coll": "CC-MAIN-2019-35"}
@sebastian-nagel
Copy link
Author

Note: the old index based on pywb 0.33.2 already recognizes the param fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pywb2 Upgrade to PyWB 2
Projects
None yet
Development

No branches or pull requests

2 participants