Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KSampler preview images async to progress #6427

Open
Silver267 opened this issue Jan 11, 2025 · 0 comments
Open

Make KSampler preview images async to progress #6427

Silver267 opened this issue Jan 11, 2025 · 0 comments
Labels
Feature A new feature to add to ComfyUI.

Comments

@Silver267
Copy link

Feature Idea

As title described, sending KSampler live preview images over slow server-client connection may cause the progress displayed on client lag behind the actual progress displayed on the server CLI. This would make image generation seem slower than actual speed on the client side (i.e. client progress bar on KSampler node shows generation is at 50% progress while server is actually at 100% progress, then client needs to wait 2x the actual generation time before receiving the final output). By turning off live preview this behaviour of client lagging behind server disappeared, and this is not a problem for sufficiently fast server-client connections (i.e. loopback), so it must be that sending the live preview is blocking the network traffic on slow connections.

Existing Solutions

No response

Other

No response

@Silver267 Silver267 added the Feature A new feature to add to ComfyUI. label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature to add to ComfyUI.
Projects
None yet
Development

No branches or pull requests

1 participant