Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clients do not know when children have been filtered #154

Open
r3ndd opened this issue Sep 13, 2023 · 1 comment
Open

Clients do not know when children have been filtered #154

r3ndd opened this issue Sep 13, 2023 · 1 comment

Comments

@r3ndd
Copy link

r3ndd commented Sep 13, 2023

Right now clients cannot distinguish between a child of an array/map being filtered and a child simply not being updated. While this may be desirable for certain applications, it is undesirable for things like distance filtering where the client does not know if an entity stopped moving or if it is out of range. It would be nice to have a "hard" or "remove" filter that triggers the onRemove event for a child on a particular client when that child is filtered, and that triggers the onAdd event when then child stops being filtered. This would require making the filtering stateful so it knows if a child has already been filtered for a particular client, but this is necessary for certain applications.

@endel
Copy link
Member

endel commented Sep 13, 2023

Hi @r3ndd, thanks for taking the time to raise the discussion.

The plan is to deprecate the current implementation of filters (see roadmap)

I still don't have a clear implementation direction yet, but it has been clear that calling the "filter callback" at every patch is not great - and re-encoding the same thing for every player is also not great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants