Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.js in ckeditor #31

Open
hoka opened this issue Feb 26, 2014 · 2 comments
Open

config.js in ckeditor #31

hoka opened this issue Feb 26, 2014 · 2 comments

Comments

@hoka
Copy link

hoka commented Feb 26, 2014

Hello,

at first thanks for this great product. I have much respect of what you are doing.

But ;)

Dealing with config.js is much much to complicated and to unflexible.

you can't cusomize it in a pretty easy way and thats for me and i think for other people a big problem.

Why is config.js not only a textarea field in settings of ckeditor, where you can put your js stuff and config stuff in?
It would make thinks for you and the user much easier.

Currently you are programming form fields to make js config customizable for the user. In my opinion it costs too much of time to make some settings editable.

The second part would be the maintenance of the product would be much easier. I you need a new config setting you no longer have to create an new form field, you only have to put it into the config string wich is avaliable through the "config.js" textarea field.

Issue #26 could be solved by the every user in a easy way if he would have full access to the config.js file. The following code would be the only thing you have to do.

CKEDITOR.on( 'dialogDefinition', function( ev )
{
// Take the dialog name and its definition from the event data.
var dialogName = ev.data.name;
var dialogDefinition = ev.data.definition;

// Check if the definition is from the dialog we're
// interested in (the 'link' dialog).
if ( dialogName == 'link' )
{
    dialogDefinition.getContents('info').get('protocol')['default']="";
}

});

I think people who wan't to customize ckeditor stuff are firm with java script and do not need a form driven customization.

Please think about it.

Btw. For me i currently patched ckeditor to get this use case running because time is money ;)

Thank to all

@gbastien
Copy link
Member

Hi @hoka

Pull requests are welcome, I would let both ways possible, and let it also be managed using a textarea for advanced user warning them that they can break things...

@gotcha @kiorky ?

Gauthier

@spereverde
Copy link
Contributor

Is this related to this? (see docs/FAQ.txt)
How to completly overload the ckeditor configuration with your own javascript config ?
Just create a javascript file called 'ckeditor_plone_config.js' in your ZMI > portal_skins > Custom or in a skin product.
Or do you want the ease of use of doing the change via the control panel per site?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants