Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /search/transactions endpoint #94

Open
fboucquez opened this issue Jan 31, 2022 · 4 comments
Open

Implement /search/transactions endpoint #94

fboucquez opened this issue Jan 31, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@fboucquez
Copy link

Hi team,

The /search/transactions seems missing. I cannot see the service and the endpoint returns 404. Would it be hard to implement?

Cheers
Fernando

@fboucquez fboucquez added the enhancement New feature or request label Jan 31, 2022
@shrimalmadhur
Copy link
Contributor

Hey @fboucquez, Yes this is not implemented yet. I will take a look how easy or hard would it be to implement.

@fboucquez
Copy link
Author

Thanks @shrimalmadhur , just for fun, I'm creating a Rosetta explorer.

https://github.com/fboucquez/rosetta-explorer

The search is pretty much required to do any type of Transaction search by hash (without knowing the block index) or transaction pagination. Block search/pagination would also be nice, but it's not in the API.

Do you know or have running rosetta nodes with different implementations. I am keen to test the explorer against different blockchains. If there are free open nodes up there, I can save time, resources, and effort setting up nodes.

I know lunar.dev used to have, but that service seems down. https://twitter.com/_lunardev

@shrimalmadhur
Copy link
Contributor

shrimalmadhur commented Feb 1, 2022

Hey @fboucquez , this is amazing. I actually was building one by myself as a way to learn react. But as a newbie JS developer it was taking time. But I think this is great and I think I can also help contribute to do this. I was initially just creating etherscan like UX without search like https://localhost:8080/block/<block_hash> so I didn't think of implementing search.

Search API - yea I think we should implement pagination. If you would like to propose changes to rosetta-specs. feel free to create an issue in that repo ( We are also working on formal Rosetta Improvement Proposal spec to make spec changes)

We currently don't have these nodes as a service. I will see what I can do. I might be able to spin up a node on AWS and share with you the endpoint if that helps.

@fboucquez
Copy link
Author

Hi @shrimalmadhur , great!

Feel free to contribute to the rosetta explorer. It's also Etherscan like, of course without any bell or whistle yet. It's fairly new, build it and have a look when you have the time.

The stack is React, NextJS, Typescript with serverside rendering using the rosetta generated client I was talking about in another issue.

If we can have external Bitcoin, Etherum, Solana, etc rosetta nodes, we can connect the explorer to them.

I would like to eventually deploy the explorer to VPC (or serverless) on AWS, Vercel, Hetzner, etc.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants