You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Actually we can get the balance atomically using ONLY RPC call.
As you can see https://eth.wiki/json-rpc/API#eth_getbalance, eth_getBalance accept second parameter as block number.
If we need to query using block hash,
get block by hash and extract block number
and use eth_getBalance using block number
The benefit of graphQL here is "it can replace the possible multiple RPC calls to one graphQL call".
So in my opinion, we don't have to use graphQL necessarily (the comment includes "MUST" keyword).
I just wondered MUST keyword at that comment.
The text was updated successfully, but these errors were encountered:
aeharvlee
changed the title
Is GraphQL is necessarily needed?
Does GraphQL necessarily needed?
Apr 1, 2022
aeharvlee
changed the title
Does GraphQL necessarily needed?
Question: Does GraphQL necessarily needed?
Apr 1, 2022
I've seen below comments and have a question here.
https://github.com/coinbase/rosetta-ethereum/blob/23561f903bc93d4fa97bebc1fbbe4c7e5b374e5e/ethereum/client.go#L1404-L1410
Actually we can get the balance atomically using ONLY RPC call.
As you can see https://eth.wiki/json-rpc/API#eth_getbalance,
eth_getBalance
accept second parameter as block number.If we need to query using block hash,
The benefit of graphQL here is "it can replace the possible multiple RPC calls to one graphQL call".
So in my opinion, we don't have to use graphQL necessarily (the comment includes "MUST" keyword).
I just wondered MUST keyword at that comment.
The text was updated successfully, but these errors were encountered: