Adding support for pydantic-v1 #128
Conversation
There was a problem hiding this comment.
Why would you need to support v1? it needs to be updated and may create a lot of issues in runtime. That will not work at all as a package cdffs based on pydantic-v2, which has been released for about a year. It will require anyone who uses cdffs to install pydantic v2+. I don't think we should go back and support versions that are not maintained, as it will create nightmare most likely.
It is mainly to allow users to use both CDF Notebooks. CDF Notebooks uses pyodide which still relies on pydantic-v1 (1.10.7 to be precise). |
Describe your changes
CDF notebooks uses pyodide which still relies on
pydantic-v1(1.10.7to be precise).cdffswas migrated topydantic v2without any backward compatibility forpydantic-v1and it creates a problem for the users who wish to usecdffson CDF notebooks.so, introducing a backward compatibility for
pydantic-v1to allow users to use CDF notebooks. It is counterintuitive approach but no other choice! :)Checklist
__init__.pyMore tests covering pydantic v1 will be added later. Is being tracked in #129