Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested edits on deleted posts are not visible in the list of pending edits #1496

Open
cellio opened this issue Dec 27, 2024 · 0 comments
Open
Labels
area: backend Changes to server-side code complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. priority: low type: change request New feature or request

Comments

@cellio
Copy link
Member

cellio commented Dec 27, 2024

meta:292505

If a post is deleted but has a pending suggested edit, which can happen rarely, that suggested edit doesn't show up in the list of pending edits, only on the deleted post itself. For users who can see deleted posts, let's include such entries on the list of pending suggestions, with the pink backgrounds to convey that these posts are currently deleted.

Why wouldn't we just throw out pending edits if a post is deleted? Because maybe user A is trying to help user B salvage a post and we don't want to lose that.

To reproduce:

  • User 1 (no abilities beyond Participate Everywhere) creates a post.
  • User 2 (no abilities ditto) suggests an edit.
  • User 1 deletes the post with the edit still pending.
  • User 3 (moderator) views the pending edits, and that one is not there.
  • User 1 can't see the list of pending edits but can view the deleted post, which shows the pending edit. (And -- just tested -- can approve the edit, leaving the post deleted as expected.)
@cellio cellio added area: backend Changes to server-side code type: change request New feature or request priority: low complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. labels Dec 27, 2024
@cellio cellio changed the title Suggested edits on deleted posts are invisible Suggested edits on deleted posts are not visible in the list of pending edits Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Changes to server-side code complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. priority: low type: change request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant