Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logged out during editing or posting: intercept and report, don't fail silently #1466

Open
cellio opened this issue Dec 5, 2024 · 0 comments
Labels
area: backend Changes to server-side code complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. priority: medium type: bug Something isn't working

Comments

@cellio
Copy link
Member

cellio commented Dec 5, 2024

meta:291621

If you start to edit a post (and I assume also if you start to create one) and get logged out, then when you go to submit the edit it fails and then the button becomes disabled, but you don't get any sort of error saying what the problem is. We don't do live updates via websockets or the like, so the page you're on can't know you've been signed out when you click the button, but when we get the failure back from the server, it would be better if we popped up an error message saying you need to log in.

One thing to check: are we at risk of losing the draft? When drafts are saved, are they tied to your browser session (it'll still be there when you log in) or to the current user? Make sure we account for that when addressing this. A big complicated edit that took you long enough that you got logged out behind the scenes is exactly the type of edit we do not want to drop on the floor.

@cellio cellio added area: backend Changes to server-side code type: bug Something isn't working priority: medium complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Changes to server-side code complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. priority: medium type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant