make page size configurable in SQLiteDatastore.new #25
Conversation
also make cache size and journal mode configurable closes #6 related to codex-storage/nim-codex#234
|
Looks great for me |
|
|
||
| if (let x = sqlite3_step(s2); x != SQLITE_ROW): | ||
| s2.dispose | ||
| return failure $sqlite3_errstr(x) |
There was a problem hiding this comment.
Probably not relevant to this PR, but how does a Result[T, string] equate to the return type of RawStmtPtr?
There was a problem hiding this comment.
It's a template, so gets expanded into the body of proc new*(T: type SQLiteDatastore, ...): ?!T, and in the case of pageSizePragmaStmt(...) the returned RawStmtPtr is assigned to let pageSizePragmaStmt = ..., for which that type is the desired one.
|
From Michael's message: There are some other pragmas (possibly some compile-time options) we may want to consider re: improving nim-codex's performance. I'm no expert, just becoming more aware of what's possible after spending more time with SQLite's docs and following links therein. https://www.sqlite.org/pragma.html#pragma_wal_autocheckpoint https://www.sqlite.org/pragma.html#pragma_mmap_size It's pretty straightforward to add support for other pragmas; doesn't necessarily have to be in a PR, could just be on a branch in status-im/nim-datastore for sake of experimentation. |
|
I think that it should have different logic - if sqlite store already exists and has different pagesize (and other parameters), it should continue to work. Ideally, it should print a notice about that, but don't stop the work. For a starter, we may just comment out code that checks parameters after setting them. Current behavior means that unlucky user will have to guess DB parameters before he can use this DB :) |
Also make cache size and journal mode configurable.
Closes #6.
Related to codex-storage/nim-codex#234.