Users can sign in for shifts in the past

[DaniGr]

If the time of a shift has already passed it should be impossible to sign in.

[klinger]

This has to be carefully implemented - there are use cases where you want to sign in after you worked on a shift - just to get your history of shifts corrected. This may be especially important if you offer incentives for working. At the deploment of Engelsystem at Chaos Communication Congress the shift-manager is the only person allowed to change the attendees of a shift after it started. (There you get a t-shirt if you work for about 15 hours in the first 4 days).

Proposal: Allow managers do to it. Make it impossible to users.

[DaniGr]

Well currently it's only possible if the day hasn't yet ended as previous days aren't displayed anyways. Please fix as it confuses people who want to sign in for the warmth bus at night. They think the morning shifts for the current day are the ones for the next day.

[numberpi]

@DaniGr On which page have you seen a shift, which has already ended, but is still displayed to sign in? The open shifts of a facility are displayed only as long as the shift is not over (as I can see it in the code).
Only if I navigate explicitly to all shifts of a facility of a date in the past, I can sign in to these shifts (and this should only be allowed by managers, as @klinger proposed).
@klinger shall volunteers have to request to sign in to a shift in the past and the manager has to confirm that, or should the manager do it via the admin backend only and nobody can sign in to shifts in the past via the frontend?

Edit: @DaniGr Ah, now I got it. If there is another shift today, which has not yet finished, then because of this one, the date is displayed under "Open shifts". Ok. And following this link you can see all shifts and sing in to them although they are in the past.
Then a first step would be to visually distinguish them? With another backgorund color?

[christophmeissner]

@Doca @pitpalme Bump. Any ideas, what this concluded to? I'm not sure, what the expected behaviour should be and what the fix should be.

[christophmeissner]

Closing issue due to inactivity.

[pitpalme]

It's unreasonable, to self-sign up a shift that ended more than 30 minutes ago.

It's only rare cases thinkable, you'd even sign up a shift, that already startet.
But "rare" might contain: "I'm on-site and volunteering in replacement for someone not showing up. For the record I should be signed up.".
Despite the fact facility managers could do "for the record" let's grant people permission to self sign up.
The same "for the record" might kick in after finishing the shift: "Could you please connect yourself with this shift?".

But if this is an issue more than 30 Minutes after shift ended, most probably someone else has tot be involved - IF the system shall not be open to arbitrary manipulation.
And if a t-shirt is granted, someone should be involved in certifying correctness, nevertheless. ;)

So to me: shifts having ended >30 minutes in the past are not decorated with any action item (aka "sign up button") and any manually triggered action, by trying to call appropriate endpoints, results in HTTP-403 or redirect to shift list and a message, stating, the action was rejected, due to lack of permission (i. e. user has no permission to "alter history").