Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse Arresting Agency for case #1063

Open
KentShikama opened this issue Apr 22, 2020 · 5 comments
Open

Parse Arresting Agency for case #1063

KentShikama opened this issue Apr 22, 2020 · 5 comments
Labels
backend Python/Make/Docker/etc. Complexity: 3 Refer to issue #739 for more details parser

Comments

@KentShikama
Copy link
Member

No description provided.

@michaelzhang43
Copy link
Contributor

The DA Number is straightforward. It's always going to be on the right column right below the Case number in the "Register of Actions". The only complication is that it's not going to be there for many cases, especially cases below the misdemeanor level, or dismissals.

Screen Shot 2020-04-23 at 9 26 45 AM

@hmarcks
Copy link
Member

hmarcks commented Apr 29, 2020

We can add it in the results here:

district-attorney-number

@KentShikama KentShikama added backend Python/Make/Docker/etc. Complexity: 2 Refer to issue #739 for more details parser labels May 17, 2020
@KentShikama
Copy link
Member Author

Linking #1181

@victorjz victorjz self-assigned this Jun 27, 2020
@victorjz
Copy link
Contributor

Parsing the DA number seems clear to me so I'll see if I can contribute that. Claimed assignment.

victorjz added a commit to victorjz/recordexpungPDX that referenced this issue Jun 28, 2020
@victorjz
[WIP] issue codeforpdx#1063 parse DA
996a2a7 
this is strictly for parsing and testing the district attorney number
unsure whether to go with least invasive additions or fully robust
case_parser new member as optional so as not to have to add arguments when calling
  the constructor throughout the project
you'll see in the new parsing method __parse_distr_atty that there's potential to return
  all the values from upper right of a given case html file but i just return DA number
would it be preferred to return more values? or return None instead of empty str?
also added testing methods to test_case_parser
victorjz added a commit to victorjz/recordexpungPDX that referenced this issue Jun 28, 2020
@victorjz
[WIP] revised issue codeforpdx#1063
052fdc0 
strictly for parsing district attorney number
made the new mebmer district_attorney_number a 'proper' member
...meaning it's no longer optional with a default value
...so constructors across the project have been revised, including in tests
did my best guessing when tests should have a blank DA number vs some value like 555
made other changes as suggested
KentShikama pushed a commit to victorjz/recordexpungPDX that referenced this issue Jul 9, 2020
@victorjz @KentShikama
[WIP] issue codeforpdx#1063 parse DA
f05d2bf 
this is strictly for parsing and testing the district attorney number
unsure whether to go with least invasive additions or fully robust
case_parser new member as optional so as not to have to add arguments when calling
  the constructor throughout the project
you'll see in the new parsing method __parse_distr_atty that there's potential to return
  all the values from upper right of a given case html file but i just return DA number
would it be preferred to return more values? or return None instead of empty str?
also added testing methods to test_case_parser
KentShikama pushed a commit to victorjz/recordexpungPDX that referenced this issue Jul 9, 2020
@victorjz @KentShikama
[WIP] revised issue codeforpdx#1063
9c61eb5 
strictly for parsing district attorney number
made the new mebmer district_attorney_number a 'proper' member
...meaning it's no longer optional with a default value
...so constructors across the project have been revised, including in tests
did my best guessing when tests should have a blank DA number vs some value like 555
made other changes as suggested
@victorjz
Copy link
Contributor

thanks for review and merge of the piece i could do. the other aspects of this issue i'm not so clear on, so i'll unassign for now. i'll browse for more issues and may even return to this one.

@KentShikama KentShikama changed the title Parse DA number and Arresting Agency for case Parse Arresting Agency for case Jul 11, 2020
@KentShikama KentShikama added Complexity: 3 Refer to issue #739 for more details and removed Complexity: 2 Refer to issue #739 for more details labels Jul 11, 2020
@KentShikama KentShikama mentioned this issue Jul 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Python/Make/Docker/etc. Complexity: 3 Refer to issue #739 for more details parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@victorjz @KentShikama @hmarcks @michaelzhang43