Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to arrival time algorithms #13

Open
liamphmurphy opened this issue Mar 12, 2022 · 2 comments
Open

Add unit tests to arrival time algorithms #13

liamphmurphy opened this issue Mar 12, 2022 · 2 comments
Labels
backend Issues related to the opentransit-metrics backend.

Comments

@liamphmurphy
Copy link
Contributor

(Original source: trynmaps/metrics-mvp#403)

Original Description:
Add tests to "data science" functions to allow newcomers to get better grasp of what functions are doing, shape of data input/output, and to allow easier changing/fixing of functions.

Functions to test are in:
backend/models/eclipses.py
backend/models/wait_times.py
backend/models/trip_times.py

Any questions about the functions or data should be directed to @youngj (Jesse Young on Slack).

For Our Purposes:
The above is pretty accurate for what would be useful to us. We can explore other places for unit tests if needed, but this is a good start.

@youngj
Copy link
Collaborator

youngj commented Mar 12, 2022

There are some unit tests in https://github.com/codeforpdx/opentransit-metrics/tree/master/backend/tests although none for eclipses.py yet. These unit tests are run automatically via GitHub Actions - e.g. https://github.com/codeforpdx/opentransit-metrics/runs/5402144883?check_suite_focus=true .

@liamphmurphy
Copy link
Contributor Author

Good catch, I'll edit the issue to add tests for eclipses.py if that makes sense?

@liamphmurphy liamphmurphy added the backend Issues related to the opentransit-metrics backend. label Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issues related to the opentransit-metrics backend.
Projects
None yet
Development

No branches or pull requests

2 participants