107 enhancement secondary partners layout updates #113
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
| <Grid item pl={'6%'} {...partnerGridStyle} order={contentOrder}> | ||
| <Typography variant="body1" p={'5% 15% 3% 0'}> | ||
| <Grid item {...partnerGridStyle} md={7} order={contentOrder}> | ||
| <Typography variant="body1" p={'5% 10% 3% 10%'}> |
There was a problem hiding this comment.
i think padding here can be 0% 10% 3% 10%, also the pt: '20px' can go.
const partnerGridStyle = {
xs: 12,
md: 6,
display: 'flex',
justifyContent: 'center',
alignItems: 'center',
flexDirection: 'column',
pt: '20px' <----
};There was a problem hiding this comment.
I pushed a commit to adjust the padding & alignment. I aligned items top, to be more like the figma file.
The CETI card looks a little off to me but not terrible there was no CETI in the initial figma mockup for comparison.
Note, I moved the 5% padding to the parent grid element. If I do the same padding on both child elements, they don't come out exactly equal. 🥳 I think this is fixable, but it seemed silly to waste too much time chasing it if padding the parent element works to make them the same size.
|
@AJSterner did you intend to close this? I don't think this issue has been resolved. Edit: Seems like this was closed by mistake. Reopening. |
|
stagnant PR and things have since been update since. can always reference and PR again if new changes are made. |
This PR:
Resolves #107
Changes for desktop version of
SecondaryPartnerscomponent only<span>if there was notestimonialAuthorprop&&short-circuit convention for consistencySecondaryPartnerscomponentScreenshots (if applicable):
Here's what it looks like with these changes
Future Steps/PRs Needed to Finish This Work (optional):
N/A