Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more descriptive labels to binary type datapoints #48

Open
dsummersl opened this issue Nov 3, 2015 · 1 comment
Open

Provide more descriptive labels to binary type datapoints #48

dsummersl opened this issue Nov 3, 2015 · 1 comment

Comments

@dsummersl
Copy link

The example we talked about at the meetup was the 'driver drunk' field. It would be better to say..."not intoxicated" instead of "no" or "intoxicated" for "yes".

We should do something similar for the following data types:

  • ambulance called
  • driver/biker drunk.
@dsummersl
Copy link
Author

Points in the code that you could use to implement this:

  1. Add a new kind of function that takes the source data ('Yes', 'No'), and allows you to return some other value ('intoxicated', etc). Similar to how the 'colors' function works here: https://github.com/BikeSafety/BikeSafety/blob/master/html/includes/angular/app.js#L183 (example: https://github.com/BikeSafety/BikeSafety/blob/master/html/includes/angular/app.js#L212). Maybe call the key convertData or something else that communicates the transformation...
  2. Modify the Legend code, so that it calls this transformation function (again, kinda like the color key is called): https://github.com/BikeSafety/BikeSafety/blob/master/html/includes/angular/MainMap.js#L78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants