Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sales / use tax for Idaho review page #4935

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

powersurge360
Copy link
Contributor

@powersurge360 powersurge360 commented Oct 31, 2024

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

Simple text box and some supporting styles

How to test?

Go to through the workflow for idaho and view the review page at the end.

Screenshots (for visual changes)

image

@powersurge360 powersurge360 added the wip denotes a work in progress that isn't ready for formal review label Oct 31, 2024
@powersurge360 powersurge360 changed the title Sales review page Added sales / use tax for Idaho review page Oct 31, 2024
Copy link

Heroku app: https://gyr-review-app-4935-0e5b44e1451f.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4935 (optionally add --tail)

@powersurge360 powersurge360 removed the wip denotes a work in progress that isn't ready for formal review label Oct 31, 2024
Copy link
Contributor

@squanto squanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@powersurge360 powersurge360 merged commit 182cd4b into main Nov 6, 2024
7 checks passed
@powersurge360 powersurge360 deleted the FYST-1005/add-sales-use-to-review branch November 6, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants