Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into a cross-browser solution for client-side validation of forms. #207

Open
monfresh opened this issue Aug 2, 2014 · 4 comments
Open

Comments

@monfresh
Copy link
Member

monfresh commented Aug 2, 2014

In browsers like Chrome and Firefox, when an input field has the required attribute enabled, an alert appears within the field to let the user know they haven't filled it out (after submitting the form). This feature is not supported in IE <10, iOS and OS X Safari, and the default Android browser.

Since we already have server-side validation in place, I recently disabled the required attribute until we can find a suitable cross-browser solution, such as the ones recommended in this guide:

http://www.html5rocks.com/en/tutorials/forms/constraintvalidation/#toc-polyfilling

monfresh added a commit that referenced this issue Aug 2, 2014
See issue #207 for desired solution.
Closes #200.
@webmaven
Copy link

Have you tried something like http://jqueryvalidation.org/documentation ?

@monfresh
Copy link
Member Author

Thanks, @webmaven! I had not tried that, but it looks like it might do the trick. What do you think, @anselmbradford ?

@anselmbradford
Copy link
Member

Sure, worth a check. Just needs to fallback gracefully in IE8 (if you want to comprehensively support XP), but since it's been around since '06 that's probably not a problem.

@monfresh monfresh added the admin label Mar 16, 2015
@monfresh monfresh changed the title Admin: Look into a cross-browser solution for client-side validation of forms. Look into a cross-browser solution for client-side validation of forms. Mar 16, 2015
@civicissuebot
Copy link

Hello! This issue looks like it still needs help!
It's been clicked on 36 times through the Civic Issue Finder on http://www.codeforamerica.org/geeks/civicissues.
Can this issue be closed or does it still need some assistance?

If you wrote this issue, you can always update the labels for specifying tasks, add more info in the description to make it easier to contribute, or re-write the title to make more contributors interested in helping out.
If you are an open source contributor, ask and see how you can help by commenting or check out more open issues in this repo at https://github.com/codeforamerica/ohana-api/issues.

Just doing a little 🌱 open source gardening 🌱 of Brigade projects!
For more info/tools for creating civic issues, check out Got Issues Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants