Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS binary is not x86_64 but arm64 #1687

Open
carlos-villavicencio-adsk opened this issue Aug 13, 2024 · 9 comments
Open

macOS binary is not x86_64 but arm64 #1687

carlos-villavicencio-adsk opened this issue Aug 13, 2024 · 9 comments
Labels
Area: Report Upload Issues with pre-ingest report uploading bug Something isn't working Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months

Comments

@carlos-villavicencio-adsk

Describe the bug
In Azure Pipelines CI, our pipeline breaks because the runner machines are x86_64 (intel) and not apple silicon (arm64) on v0.8.0.

v0.7.3 is x86_64 for reference. Is it possible to build a fat binary?

To Reproduce
Steps to reproduce the behavior:

  1. Get https://uploader.codecov.io/v0.8.0/macos/codecov
  2. On macOS execute lipo -archs codecov
  3. See the architecture type.

Expected behavior
Have a fat binary that bundles x86_64 and arm64 architectures.

@carlos-villavicencio-adsk carlos-villavicencio-adsk added the bug Something isn't working label Aug 13, 2024
@thomasrockhu-codecov thomasrockhu-codecov added Area: Report Upload Issues with pre-ingest report uploading Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months labels Aug 13, 2024
@nikosatwork
Copy link

Hi @drazisil-codecov - after updating our self-hosted instance to v24.8.1 or v24.9.3 the mac uploader is failing due to this. Would you know if the mac uploader would be set to v0.7.3 in a future version of codecov? As far as I understand this was implemented with shotgunsoftware/tk-ci-tools#53, but it seems that latest v24.9.3 still uses v0.8.0. Thank you!

@drazisil-codecov
Copy link
Contributor

Hi @nikosatwork ,

You are referring to the copy in the self-hosted?

@nikosatwork
Copy link

Hi, yes

@paulofierro
Copy link

We're having the same issue on Github Actions, as the runners are x86 based. For now we're rolling back and using 0.7.3 of the uploader as that is built for x86_64.

Building a fat binary is definitely the way to go here. 👍

Also, swapping from one architecture to the other without warning in a minor release isn't great.

@nikosatwork
Copy link

Hi @drazisil-codecov. Are there any updates on this? Thank you.

@drazisil-codecov
Copy link
Contributor

(cc: @rohan-at-sentry

@drazisil-codecov
Copy link
Contributor

Hi @nikosatwork can you please try using the CLI? https://docs.codecov.com/docs/codecov-uploader

@nikosatwork
Copy link

@drazisil-codecov will do. In the meantime, could you please point me to the location of the uploader in the pod so we could replace it with v0.7.3 (i.e. where can we find codecov.domain.com/uploader?) Thank you.

@drazisil-codecov
Copy link
Contributor

Hi @nikosatwork ,

I believe it's here https://github.com/codecov/gazebo/blob/bd8b644fff48fc5bcdd06ed1ac1170b258b847da/docker/nginx-no-ipv6.conf#L51-L54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Report Upload Issues with pre-ingest report uploading bug Something isn't working Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months
Projects
None yet
Development

No branches or pull requests

5 participants