Player size options are confusing

[neekt]

Bug Report:

⚬ BUG: The player size options are not working properly on Firefox for Linux. The sidebar to the right of the video seems to be preventing the player from resizing properly.

⚬ HOW:

1. Play a YouTube video (e.g.: https://www.youtube.com/watch?v=g56QT0k2Jb4)
2. In the extension preferences, go to Appearance > Player > Player size, and select any of the options (e.g. 'Max. width within page', 'Fit to window', etc.).
3. Observe that the video is not resized to fit to the window, or to the max width within page, etc., but instead to within the page to the left of the sidebar.
4. ALTERNATIVELY: Make sure that Player > Buttons > Fit to Window is active, and toggle the button while the video is playing (see example screen recording below).

This is my first time using the extension, so I don't know if it's a YouTube change or extension version change, or when this became an issue. I haven't tested it on any other OS.

I reproduced the issue on a fresh Firefox profile with no other extensions installed.

---

More / optionally:

⚬ Screen recording:

Untitled.Project.mp4

⚬ Browser: Firefox for Linux 121.0
⚬ OS: Linux Mint 21.2 Cinnamon
⚬ Extension version: 4.581

Thanks for maintaining this extension!

[ImprovedTube]

hi @neekt!

• 1.) full height & fit to window (same as the player-button), both make more sense with YouTube's theater-mode. (or else vertical screens/windows). That's why the "force theater mode" switch was once placed right below, so that there is a chance users see it.

  • moved it up to be the first option under appeareance: player: 80832a5
  • and we can add something to the end of the player-size drop down to click the force theater mode switch automatically when activating one of the options. ( Our UI generates HTML from JS objects with our satus.js, which i didnt write, so i cant solve it instantly.
    ,on: { click: function () {
    if (satus.storage.get('player_size') !== "fit_to_window" || satus.storage.get('player_size') !== "full_height")) {
    ,on: { "change of value" : function () {

   setTimeout(() => {
    if (satus.storage.get('player_size') === "fit_to_window" || satus.storage.get('player_size') === "full_height") ) {
    if (!satus.storage.get('forced_theater_mode') || satus.storage.get('forced_theater_mode') !== true) {
   	this.previousSibling.click();	} 	}	}, 250); }  }	} 
  
  (and if we changed it in storage that won't be not animated like the switch, 
  while our UI loads storage only once when opened)		

• 2.) the option max, width within the page doesn't help in theater mode. (In theater mode all the 3 options can do the same). (and youtube changed & we might still have to update how we even notice theater mode in our CSS? to possible easily exclude the feature from it.)

• 3.) the fit to window player-button should also trigger theater-mode usually. Fitting its icon with a diagonal arrow. (while a variant without theater-mode would have a vertical arrow, as mentioned here 'Fit To Window' Player button #1798 (comment) . Thanks again for your work @D-Rekk

[D-Rekk]

@neekt I don't completely understand. Are you saying labels are confusing or the player sizes are not working?
By the shown video seems that the FTW button is working properly. Fit-To-Window grows the height of the player. If you want to have a full Twitch-like experience you can enable Comments -> Sidebar and use Fit-To-Window player size

[neekt]

Thanks for the explanation and update @ImprovedTube. Using Fit to Window (or Fit to Height) with theater mode enabled, as well as hiding the header on video pages (under Appearance > Header > Position), gives the result I was expecting: the video taking up the full height of the browser window.

I think your suggestion of forcing theater mode when selecting fit to height/window is a good one (and maybe forcing a static header too, so the full browser window height can be utilised?).

the fit to window player-button should also trigger theater-mode usually

That's definitely not happening for me - specifically, when Force theater mode is off, player size is "Don't change", and the video begins playing in default view (as in the video I attached).

@D-Rekk I expected that Fit to Window would fit the video to the full height of the browser window (or to the full width, if the browser height is greater than the width), regardless of whether default or theater mode was selected. That's not what was happening in the video - I can see vertical padding is added to the player window, but the size of the actual video doesn't change.

I'm not a Twitch user so I'm not sure what you mean about that.

[ImprovedTube]

• [ ]

That's definitely not happening for me

yes @neekt, i mean it shall (check-box to-do list), (since currently it is just doing "full height")

#1798 (comment)

1.) max. video width "Fit to page"
options to select: [always | player-button #556 ]

( + and more options for the youtube header: hide in theater mode|hover in theater mode ))

---

while "Fit-to-window" can be repaired (it used to only go for width, as you'd expect, but does fthe same as full height, ever since it is outdated (why "max width" was attempted. And "Full height could be renamed as "100% available height" i guess)

---

while the current function of @D-Rekk's button can be kept with a horizontal facing arrow icon & renamed as "full available height" button (importing(respecting) the existing setting to the new name as done in the top of our background.js):

2.) Full Player height
options to select: [in theater-mode | always | can keep a button > too, yet different icon with vertical arrow?]