diff --git a/Makefile b/Makefile index 47b67a012..2628f1395 100644 --- a/Makefile +++ b/Makefile @@ -1,8 +1,10 @@ FEATURES ?= "default" SVSM_ARGS = --features ${FEATURES} -FEATURES_TEST ?= "default-test" -SVSM_ARGS_TEST = --no-default-features --features ${FEATURES_TEST} +SVSM_ARGS_TEST = --no-default-features +ifdef FEATURES_TEST + SVSM_ARGS_TEST += --features ${FEATURES_TEST} +endif ifdef RELEASE TARGET_PATH=release diff --git a/kernel/Cargo.toml b/kernel/Cargo.toml index 8e8c01267..b1f489ded 100644 --- a/kernel/Cargo.toml +++ b/kernel/Cargo.toml @@ -38,7 +38,6 @@ test.workspace = true [features] default = ["mstpm"] -default-test = [] enable-gdb = ["dep:gdbstub", "dep:gdbstub_arch"] mstpm = ["dep:libmstpm"] diff --git a/kernel/build.rs b/kernel/build.rs index 1f9ccb89b..2a43d34fb 100644 --- a/kernel/build.rs +++ b/kernel/build.rs @@ -21,9 +21,7 @@ fn main() { println!("cargo:rustc-link-arg-bin=svsm=--no-relax"); println!("cargo:rustc-link-arg-bin=svsm=-Tkernel/src/svsm.lds"); println!("cargo:rustc-link-arg-bin=svsm=-no-pie"); - if std::env::var("CARGO_FEATURE_MSTPM").is_ok() - && std::env::var("CARGO_FEATURE_DEFAULT_TEST").is_err() - { + if std::env::var("CARGO_FEATURE_MSTPM").is_ok() && std::env::var("CARGO_CFG_TEST").is_err() { println!("cargo:rustc-link-arg-bin=svsm=-Llibmstpm"); println!("cargo:rustc-link-arg-bin=svsm=-lmstpm"); } diff --git a/kernel/src/debug/gdbstub.rs b/kernel/src/debug/gdbstub.rs index 37d4ad79a..0459d4a47 100644 --- a/kernel/src/debug/gdbstub.rs +++ b/kernel/src/debug/gdbstub.rs @@ -313,7 +313,7 @@ pub mod svsm_gdbstub { Self {} } - fn read(&mut self) -> Result { + fn read(&self) -> Result { unsafe { Ok(GDB_SERIAL.get_byte()) } } }