Skip to content
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

Toggling shortcut handling? e.g. an off-mode #157

Open
mcint opened this issue Mar 5, 2021 · 6 comments
Open

Toggling shortcut handling? e.g. an off-mode #157

mcint opened this issue Mar 5, 2021 · 6 comments

Comments

@mcint
Copy link

mcint commented Mar 5, 2021

I'm looking to add functionality to rxhanson/Rectangle (discussion), which relies on MASShortcut and listens globally (vs just while focused), to toggle shortcut handling on and off. I would like to have a shortcut, which enables and disables handling of shortcuts by the client app, allowing me to use the same shortcuts in other apps.

Is this kind of functionality currently possible? Is it easy, as in supported for groups of shortcuts, e.g. all but the toggling key combination?

@shpakovski
Copy link
Collaborator

Hi @mcint 👋 There is no such property as isEnabled, although it’s a great idea. You have to register and unregister manually, if I get your question correctly. Sorry for the slow reply!

@mcint
Copy link
Author

mcint commented Apr 10, 2022

Thanks @shpakovski 👋 . If I were interested in implementing this feature, I might go a little further and make activate-able groups, just implementing 1 app-wide by default.
Mmm, I need to sketch out for myself how MAS instances in applications fit into the system.

It looks like #115 is a good foundation for what I'm looking for here. Ah, you are merging PRs. Any limitations or concerns about #115 ?

@shpakovski
Copy link
Collaborator

The #115 has got conflicts with the main branch, but this looks like what you are looking for.

@RaimundasSakalauskas
Copy link

@shpakovski #115 fixes quite an important flaw of this library. Any plans to ever get that PR (or new PR with similar functionality) merged?

@shpakovski
Copy link
Collaborator

@RaimundasSakalauskas Thank you for the heads up. That PR has got unresolved conflicts. Could you please fix them first?

@RaimundasSakalauskas
Copy link

Maybe original author of the PR would like to do it? Post a comment on the PR. I am currently working on MVP app that uses this lib, so since this is MVP that lacks 80% of features, this UX issue is very low on priority list. Like they said in chernobyl movie "not great, not terrible".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants