Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metamorphic: use the cockroach key schema #4167

Closed
jbowens opened this issue Nov 13, 2024 · 0 comments · Fixed by #4304
Closed

metamorphic: use the cockroach key schema #4167

jbowens opened this issue Nov 13, 2024 · 0 comments · Fixed by #4304
Assignees
@jbowens
Labels
A-storage T-storage

Comments

@jbowens
Copy link
Collaborator

jbowens commented Nov 13, 2024 •
edited by cockroach-jira-scripts
Loading

Currently the metamorphic test uses the testkeys comparer and key schema. There's significant complexity in the Cockroach implementation of the key schema and comparer, and we'd get better coverage if we used the Cockroach key schema in the metamorphic tests.

Jira issue: PEBBLE-304
@jbowens jbowens self-assigned this Dec 4, 2024
jbowens added a commit to jbowens/pebble that referenced this issue Dec 30, 2024
@jbowens
metamorphic: allow KeyFormat to specify a KeySchema
604a979 
Allow KeyFormat to specify a KeySchema that should be used by the metamorphic
tests for columnar block sstables. This is in preparation for use of the
cockroachkvs package within the metamorphic test.

Informs cockroachdb#4167.
@jbowens jbowens mentioned this issue Dec 30, 2024
Merged
jbowens added a commit that referenced this issue Dec 31, 2024
@jbowens
metamorphic: allow KeyFormat to specify a KeySchema
c7e1b5a 
Allow KeyFormat to specify a KeySchema that should be used by the metamorphic
tests for columnar block sstables. This is in preparation for use of the
cockroachkvs package within the metamorphic test.

Informs #4167.
@jbowens jbowens mentioned this issue Jan 27, 2025
Merged
jbowens added a commit to jbowens/pebble that referenced this issue Jan 29, 2025
@jbowens
metamorphic: add CockroachKeyFormat
5affc63 
Add a new KeyFormat that uses the cockroach encoding of KV pairs in the
metamorphic test, expanding test coverage to cover the cockroachkvs package.

Fixes cockroachdb#4167.
jbowens added a commit to jbowens/pebble that referenced this issue Jan 29, 2025
@jbowens
metamorphic: add CockroachKeyFormat
d88f585 
Add a new KeyFormat that uses the cockroach encoding of KV pairs in the
metamorphic test, expanding test coverage to cover the cockroachkvs package.

Fixes cockroachdb#4167.
@jbowens jbowens mentioned this issue Jan 29, 2025
Merged
jbowens added a commit to jbowens/pebble that referenced this issue Jan 29, 2025
@jbowens
metamorphic: add CockroachKeyFormat
bb38471 
Add a new KeyFormat that uses the cockroach encoding of KV pairs in the
metamorphic test, expanding test coverage to cover the cockroachkvs package.

Fixes cockroachdb#4167.
jbowens added a commit to jbowens/pebble that referenced this issue Jan 30, 2025
@jbowens
metamorphic: add CockroachKeyFormat
e5aa184 
Add a new KeyFormat that uses the cockroach encoding of KV pairs in the
metamorphic test, expanding test coverage to cover the cockroachkvs package.

Fixes cockroachdb#4167.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbowens jbowens

Labels
A-storage T-storage
Projects
No open projects
[Deprecated] Storage
Status: Incoming
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metamorphic: add CockroachKeyFormat jbowens/pebble
1 participant
@jbowens