Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

目前存在的登录问题 #116

Open
alsotang opened this issue Apr 11, 2018 · 5 comments
Open

目前存在的登录问题 #116

alsotang opened this issue Apr 11, 2018 · 5 comments

Comments

@alsotang
Copy link
Member

  1. https://cnodejs.org/signin 登录页面随便输入账号名密码,点击登录没有任何反映
  2. github在https://github.com/settings/profile 如果没有展示public email的话,登录会直接500,没有正确提示。并且当 email 和 用户名重复时,也需要有明确提示。参见 app.js 中的 githubHandler
  3. 找回密码收不到邮件

已经修复的问题,新用户 accessToken 的生成逻辑完善。空白 accessToken 用户通过 bin/generate_access_token.js 来补充。

鉴于以上问题都挺严重的,建议回滚老版本。

问题2的github登录问题,我尝试了几个方式,都没法拿到 githubHandler 中的错误信息,导致外层没数据作出正确响应。这个 passport 库的封装挺神奇的。本来 passport.js 是为 express 那套中间件所写,eggjs在上面包了一层逻辑,不过对于错误的抛出应该给出更明确的指导。

@fengmk2
Copy link
Member

fengmk2 commented Apr 11, 2018

都 500 页面了,肯定有 common-error.log 里面有日志,请将日志找出来贴上来。

@shawn-msft
Copy link

我这边github登陆直接是Cannot GET /passport/github/callback

@alsotang
Copy link
Member Author

@fengmk2 日志有,而且error stack能看到的特别浅,就一层。朴灵在看了。

@shadowcz007
Copy link

没有展示public email的话,还没解决吗?

@fxxqq
Copy link

fxxqq commented Feb 5, 2020

登陆的这些问题不打算修复了么

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants