Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary definition of Project Maintainer overstates the terms usage in CNCF #471

Open
lizrice opened this issue Jul 25, 2023 · 7 comments
Assignees

Comments

@lizrice
Copy link

lizrice commented Jul 25, 2023

Under "Project Maintainer" the text says

In CNCF, term “maintainer” is used over other similar terms such as “committer”.

This simply not true - both terms are used more-or-less interchangeably. For example the Charter uses the term "committer". Some projects use "maintainer" and others use "committer".

(I suspect that terms like "contributor", "community member" and others may also have project-specific usage.

@aliok
Copy link
Member

aliok commented Jul 25, 2023

Thanks for the feedback @lizrice

In CNCF, term “maintainer” is used over other similar terms such as “committer”.

We can simply remove that sentence. Later on, once there's an outcome from the discussion in that TOC ticket, we can update our definitions.

@craigbox
Copy link

See also cncf/foundation#433

(Who processes that queue, and can I ask them why that issue hasn't had any response in almost a year?)

@jberkus
Copy link
Contributor

jberkus commented Sep 29, 2023

The terms are used interchangeably and that is a problem because they do not mean the same thing. Maintainer means something; committer does not. Disagree with the change.

@craigbox
Copy link

craigbox commented Oct 5, 2023

The section in question is https://contribute.cncf.io/resources/glossary/#project-maintainer (I had to look it up.)

I think I see the problem.

A project maintainer is an individual or a group responsible for managing and overseeing the development, coordination, and overall health of an open source project. Maintainers review contributions, make decisions, and guide the project’s direction. In CNCF, term “maintainer” is used over other similar terms such as “committer”.

In my head, committers, as "people who can change the code", are the people who most commonly review the contributions that other people (other committers or drive-by contributors) make. Maintainers are a group above that on the ladder, who do all the rest of the things that are specified.

CNCF does not correctly understand that distinction. Can someone please look at cncf/foundation#433 ?

@jberkus
Copy link
Contributor

jberkus commented Oct 5, 2023

The term "committers" means something different in the world of git, today. Everyone who has a merged change is a committer. This is what Devstats displays when you filter on "committers"; it's everyone who contributed to a PR. It's not a leadership position.

This is why the CNCF staff refers to maintainers everywhere, and doesn't talk to committers.

As such, the CNCF as an organization should NOT be using the term committer to refer to project leaders of any kind. It's misleading and confusing for engineers. Nobody I've seen arguing to use the term committer has been an engineer.

@craigbox
Copy link

craigbox commented Oct 5, 2023 via email

@jberkus
Copy link
Contributor

jberkus commented Oct 10, 2023

The reason I'm focusing on the term "maintainer" is that it's already used to signify project leaders in many places in the CNCF, for example: https://github.com/cncf/foundation/blob/main/project-maintainers.csv .

If we use Maintainer for "project leaders as recognized by the CNCF", that leaves Approver, Owner, Committer, or whatever that projects can use for their own "can merge code but not a leader" category, if they need one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Assigned
Development

No branches or pull requests

5 participants