Event::getByToken bug in CutBasedElectronID

[Dr15Jones]

The lines

cmssw/RecoEgamma/ElectronIdentification/plugins/CutBasedElectronID.cc

Lines 467 to 469 in f912613

	edm::Handle<reco::BeamSpot> pBeamSpot;
	// uses the same name for the vertex collection to avoid adding more new names
	e.getByToken(verticesCollection_, pBeamSpot);

will always result in a failure because the type of verticesCollection_ does not match BeamSpot

cmssw/RecoEgamma/ElectronIdentification/plugins/CutBasedElectronID.h

Line 30 in 41a8d65

edm::EDGetTokenT<std::vector<reco::Vertex> > verticesCollection_;

Such a mismatch was intended to be caught at compile time but didn't happen because the compiler found the overload

cmssw/FWCore/Framework/interface/Event.h

Lines 180 to 181 in 41a8d65

	template <typename PROD>
	bool getByToken(EDGetToken token, Handle<PROD>& result) const;

and used that.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

A new Issue was created by @Dr15Jones.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[Dr15Jones]

assign RecoEgamma/ElectronIdentification

[Dr15Jones]

assign core

[cmsbuild]

New categories assigned: reconstruction,core

@Dr15Jones,@jfernan2,@makortel,@mandrenguyen,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

[Dr15Jones]

A bit of git archeology shows this has been broken for 10 years.

[jfernan2]

@SanghyunKo @cochando as L3 Reco EGamma conveners, can you please have a look and provide a solution? Thanks

[Dr15Jones]

I actually have a fix for this one coming as part of a general memory improvement I'm doing to ElectronIDExternalProducer and its helpers.

[makortel]

Such a mismatch was intended to be caught at compile time but didn't happen because the compiler found the overload

cmssw/FWCore/Framework/interface/Event.h

Lines 180 to 181 in 41a8d65

	template <typename PROD>
	bool getByToken(EDGetToken token, Handle<PROD>& result) const;

and used that.

Maybe we should finally remove the non-templated EDGetToken (and EDPutToken) (we have already thought about it cms-sw/framework-team#431)