Class template edm::IDGeneratorSourceBase<T> needs some refactoring

[makortel]

#46790 added a Source (EmptySourceFromEventIDs ) that inherits from edm::IDGeneratorSourceBase<edm::InputSource>, but makes no use of IDGeneratorSourceBase's configuration parameters

cmssw/FWCore/Sources/src/IDGeneratorSourceBase.cc

Lines 265 to 287 in 6ac9132

	desc.addOptionalUntracked<unsigned int>("numberEventsInRun")
	->setComment("Number of events to generate in each run.");
	desc.addOptionalUntracked<unsigned int>("numberEventsInLuminosityBlock")
	->setComment("Number of events to generate in each lumi.");
	desc.addUntracked<unsigned long long>("firstTime", 1)->setComment("Time before first event (ns) (for timestamp).");
	desc.addUntracked<unsigned long long>("timeBetweenEvents", kNanoSecPerSec / kAveEventPerSec)
	->setComment("Time between consecutive events (ns) (for timestamp).");
	desc.addUntracked<unsigned int>("eventCreationDelay", 0)
	->setComment("Real time delay between generation of consecutive events (ms).");
	desc.addNode(edm::ParameterDescription<unsigned int>("firstEvent", 1U, false) xor
	edm::ParameterDescription<unsigned long long>("firstEvent", 1ULL, false))
	->setComment(
	"'firstEvent' is an XOR group because it can have type uint32 or uint64, default:1\n"
	"Event number of first event to generate.");
	desc.addUntracked<unsigned int>("firstLuminosityBlock", 1)
	->setComment("Luminosity block number of first lumi to generate.");
	desc.addUntracked<unsigned int>("firstRun", 1)->setComment("Run number of first run to generate.");
	desc.addUntracked<std::vector<edm::LuminosityBlockID>>("firstLuminosityBlockForEachRun", {})
	->setComment(
	"When the source makes a new LuminosityBlock, this list is checked to see what Run number should be used. "
	"The LuminosityBlock numbers are required to be in ascending order.");

We should refactor edm::IDGeneratorSourceBase<T> such that the configuration parameters above, and all logic related to them, would be separated from the part that EmptySourceFromEventIDs uses.

[makortel]

assign core

[cmsbuild]

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

cms-bot internal usage

[cmsbuild]

A new Issue was created by @makortel.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here