Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Using main cmssw repository for L1Tracking development #46748

Open
iarspider opened this issue Nov 20, 2024 · 9 comments
Open

[RFC] Using main cmssw repository for L1Tracking development #46748

iarspider opened this issue Nov 20, 2024 · 9 comments

Comments

@iarspider
Copy link
Contributor

As discussed during yesterday's Core Software meeting, we propose the following solution for better integration of L1Tracking development in CMSSW:

  • Create a new category (similar to, e.g. heterogeneous) and add these pacakges to it: L1Trigger/TrackFindingTracklet, L1Trigger/TrackFindingTMTT, L1Trigger/TrackerTFP, L1Trigger/TrackerDTC, L1Trigger/TrackTrigger, DataFormats/L1TrackTrigger
    • These packages currently are in l1 category, we can move them out
  • Add corresponding experts to that category
  • Add special tests (similar to, e.g., gpu) that can be requested in addition to regular tests

This way, when a PR is opened that changes files under these packages, only the relevant experts will be notified, and their signature will be required to merge the PR.

@tomalin FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 20, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @iarspider.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

thanks @iarspider for opening this issue.

These packages currently are in l1 category, we can move them out

The should remain under l1. We just add these packages under new l1track too

@smuzaffar
Copy link
Contributor

type doc

@smuzaffar
Copy link
Contributor

Add special tests (similar to, e.g., gpu) that can be requested in addition to regular tests

@tomalin , for additional l1track tests, we need to teach bot how to recognize it and what to run. You can see cms-sw/cms-bot#2354 and cms-sw/cms-bot#2240 as examples for running enable and run extra PR test. @cms-sw/externals-l2 can take care of it if you point us your current test ( run via gitlab ci) Or feel free to open cms-bot PR

@makortel
Copy link
Contributor

assign l1

@cmsbuild
Copy link
Contributor

New categories assigned: l1

@aloeliger,@epalencia you have been requested to review this Pull request/Issue and eventually sign? Thanks

@tomalin
Copy link
Contributor

tomalin commented Dec 4, 2024

Thanks @smuzaffar . How do I add experts to the new l1track git-group, that will sign off on PRs?

Our current git CI test works like this:

  1. In the L1track group's CMSSW github fork, our github CI https://github.com/cms-L1TK/cmssw/blob/L1TK-dev-14_2_0_pre4/.github/workflows/github_CI.yml is run when someone makes a PR to our development branch.

  2. Our github CI calls the utility https://github.com/cms-L1TK/gitlab-mirror-and-ci-action , to trigger a git CI job to run on gitlab.

  3. The gitlab CI job compiles & runs our CMSSW L1 track code. It is https://gitlab.cern.ch/cms-l1tk/cmssw_CI/-/blob/masterCI/.gitlab-ci.yml .

It's not obvious to me how to translate (3) for your "bot". I'll be at CERN for CMS week, if talking in person would help?

@smuzaffar
Copy link
Contributor

smuzaffar commented Dec 17, 2024

How do I add experts to the new l1track git-group, that will sign off on PRs?

You can open a PR with updated CMSSW_L2 here and add members responsible for l1track or let us know the github usernames and we can update it. Once that change is in then one can explicitly do assign l1track to notify l1track members about the PR . In this case bot will add l1track-pending label which l1track members can sign off.

We will look in to your CI script and add those to cms-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants