-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Using main cmssw repository for L1Tracking development #46748
Comments
cms-bot internal usage |
A new Issue was created by @iarspider. @Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
thanks @iarspider for opening this issue.
The should remain under |
type doc |
@tomalin , for additional |
assign l1 |
New categories assigned: l1 @aloeliger,@epalencia you have been requested to review this Pull request/Issue and eventually sign? Thanks |
Thanks @smuzaffar . How do I add experts to the new l1track git-group, that will sign off on PRs? Our current git CI test works like this:
It's not obvious to me how to translate (3) for your "bot". I'll be at CERN for CMS week, if talking in person would help? |
You can open a PR with updated We will look in to your CI script and add those to cms-bot |
As discussed during yesterday's Core Software meeting, we propose the following solution for better integration of L1Tracking development in CMSSW:
heterogeneous
) and add these pacakges to it:L1Trigger/TrackFindingTracklet
,L1Trigger/TrackFindingTMTT
,L1Trigger/TrackerTFP
,L1Trigger/TrackerDTC
,L1Trigger/TrackTrigger
,DataFormats/L1TrackTrigger
l1
category, we can move them outgpu
) that can be requested in addition to regular testsThis way, when a PR is opened that changes files under these packages, only the relevant experts will be notified, and their signature will be required to merge the PR.
@tomalin FYI
The text was updated successfully, but these errors were encountered: