Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run profiling on baseline release and save root output for comparison of RECO process for PRs #46602

Closed
gartung opened this issue Nov 4, 2024 · 7 comments

Comments

@gartung
Copy link
Member

gartung commented Nov 4, 2024

I need to set the number of events to 100 and I wanted to avoid running that many for every IB.

Step 1 and step 2 are run for each job so technically the input for step3 RECO is different. On average the results should be the same but not with the limited stats of 10 events.

Saving the output root files and json files from the two workflows used in profiling would allow profiling the PR with the same RECO input as the baseline.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

A new Issue was created by @gartung.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented Nov 4, 2024

cms-sw/cms-bot#2366

@gartung
Copy link
Member Author

gartung commented Nov 5, 2024

Using the same input step2.root for the RECO step still results in larger differences in module timing than expected.
Perhaps taking difference of the fraction of the total time would be a better metric.

@gartung gartung closed this as completed Nov 5, 2024
@makortel
Copy link
Contributor

makortel commented Nov 6, 2024

Are the step1 and/or step2 run with multiple threads in the profiling workflow? On a single thread their output should be exactly the same (which is verified in PR test comparisons).

@gartung
Copy link
Member Author

gartung commented Nov 6, 2024

All jobs are run single threaded.

@gartung
Copy link
Member Author

gartung commented Nov 6, 2024

The differences in total job time might be caused by running on different VMs. I am modifying the PR profiling script to run both IB and IB+PR profiling on the same VM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants