Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in #120 that need to be propagated elsewhere #121

Open
22 of 24 tasks
makortel opened this issue Nov 5, 2020 · 0 comments
Open
22 of 24 tasks

Changes in #120 that need to be propagated elsewhere #121

makortel opened this issue Nov 5, 2020 · 0 comments

Comments

@makortel
Copy link
Collaborator

makortel commented Nov 5, 2020

This issue is to track the propagation of the update #120 in cudadev to other programs.

The changes from cudadev to

  • cuda and
  • cudauvm

are straightforward to figure out (just merge by hand e.g. with meld). Also,

  • cudauvm and
  • cudatest

should be synchronized from cuda.

The https://github.com/cms-patatrack/pixeltrack-standalone/blob/master/doc/CodeStructure.md needs to be updated for

  • links to code in cuda
  • reference profile

Changes to kokkos require a bit more care, here is the list of files (in cudadev) that need to be looked at

  • src/cudadev/CUDACore/AtomicPairCounter.h: add namespaces
  • src/cudadev/CUDACore/GPUSimpleVector.h: rename to SimpleVector, rename namespace
  • src/cudadev/CUDACore/GPUVecArray.h: rename to VecArray, rename namespace
  • src/cudadev/CUDACore/HistoContainer.h: move remaining functions and types into namespace
  • Move BeamSpotCUDA::Data to BeamSpotPOD
    • src/cudadev/CUDADataFormats/BeamSpotCUDA.h
    • src/cudadev/plugin-BeamSpotProducer/BeamSpotESProducer.cc
    • src/cudadev/plugin-BeamSpotProducer/BeamSpotToCUDA.cc
  • src/cudadev/CUDADataFormats/ZVertexSoA.h: MAXTRACKS = 16 * 1024 to MAXTRACKS = 32 * 1024
  • add pixelCPEforGPU::DetParams::pixmx member (requires an update of binary dumps):
    • src/cudadev/CondFormats/pixelCPEforGPU.h
    • src/cudadev/plugin-SiPixelRecHits/gpuPixelRecHits.h
  • src/cudadev/DataFormats/approx_atan2.h: add parentheses
  • src/cudadev/plugin-PixelTriplets/BrokenLine.h, src/cudadev/plugin-PixelTriplets/RiemannFitOnGPU.h: use namespaces explicitly, some rewording
  • src/cudadev/plugin-PixelTriplets/BrokenLineFitOnGPU.h: remove using namespace Eigen
  • src/cudadev/plugin-PixelTriplets/CAConstants.h: changes in constants
  • device_theCellNeighbors_ and device_theCellTracks_ apparently get used now (list of files below is incomplete)
    • src/cudadev/plugin-PixelTriplets/CAHitNtupletGeneratorKernels.cu
    • src/cudadev/plugin-PixelTriplets/CAHitNtupletGeneratorKernelsImpl.h
    • src/cudadev/plugin-PixelTriplets/GPUCACell.h
    • src/cudadev/plugin-PixelTriplets/gpuPixelDoublets.h
  • src/cudadev/plugin-PixelTriplets/CAHitNtupletGeneratorKernelsImpl.h: remove using namespace gpuPixelDoublets
  • src/cudadev/plugin-PixelTriplets/CAHitNtupletGeneratorOnGPU.cc: fitter memory allocation is moved a bit later
  • src/cudadev/plugin-PixelTriplets/choleskyInversion.h: rename namespace, add empty lines between functions
  • add isRun2_ boolean flag, set to true
    • src/cudadev/plugin-SiPixelClusterizer/SiPixelRawToClusterCUDA.cc
    • src/cudadev/plugin-SiPixelClusterizer/SiPixelRawToClusterGPUKernel.h
    • src/cudadev/plugin-SiPixelClusterizer/SiPixelRawToClusterGPUKernel.cu
    • src/cudadev/plugin-SiPixelClusterizer/gpuCalibPixel.h
  • src/cudadev/plugin-SiPixelRecHits/gpuPixelRecHits.h: one-line if inside #ifdef GPU_DEBUG
  • src/cudadev/test/VertexFinder_t.h: remove using namespace gpuVertexFinder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant