Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up EventFilter/HcalRawToDigi/plugins/HcalDigisProducerGPU.cc #536

Open
fwyzard opened this issue Aug 16, 2020 · 0 comments
Open

clean up EventFilter/HcalRawToDigi/plugins/HcalDigisProducerGPU.cc #536

fwyzard opened this issue Aug 16, 2020 · 0 comments

Comments

@fwyzard
Copy link

fwyzard commented Aug 16, 2020

  1. clear host buffers once the copy has completed (so in produce()):
  // clear host buffers
  hf01_.clear();
  hf5_.clear();
  hf3_.clear();

  1. add a runtime check that the "maxChannels" sizes are not overrun

  2. check what is a good value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fwyzard