Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the Patatrack branch for merging into CMSSW #200

Closed
fwyzard opened this issue Nov 27, 2018 · 6 comments
Closed

Prepare the Patatrack branch for merging into CMSSW #200

fwyzard opened this issue Nov 27, 2018 · 6 comments
Assignees

Comments

@fwyzard
Copy link

fwyzard commented Nov 27, 2018

Track here any issues related to merging the Patatrack branch with the upstream CMSSW master branch.

@fwyzard fwyzard changed the title Prepare CMSSW_10_4_XP_Patatrack for merging into CMSSW_10_4_X Prepare CMSSW_10_4_X_Patatrack for merging into CMSSW_10_4_X Nov 27, 2018
@fwyzard
Copy link
Author

fwyzard commented Nov 27, 2018

Work to be integrated before the final upstream submission:

Do we need to include these files ?

  • 27kB / 1.8k lines: EventFilter/SiPixelRawToDigi/test/RawId_moduleId.txt
  • 3.7MB / 53k lines: EventFilter/SiPixelRawToDigi/test/Pixel_Phase1_Raw2Digi_GPU_Cabling_Map.dat
  • 2.1MB / 6.3k lines: RecoPixelVertexing/PixelTriplets/test/pixHits.ipynb

Fix conflicts with CMSSW master branch:

RFC PR for master: cms-sw#25647 .

@fwyzard
Copy link
Author

fwyzard commented Nov 27, 2018

Remove obsolete files under EventFilter/SiPixelRawToDigi/test/ with #201 .

@makortel
Copy link

I'd like to see #100 included and all modules migrated to it before merging to CMSSW master (after completing the steps in #100 (comment)). We can of course revisit this after all other steps have been finished if my plan takes long to execute.

@makortel

This comment has been minimized.

@fwyzard

This comment has been minimized.

@fwyzard fwyzard self-assigned this Dec 14, 2018
@fwyzard fwyzard changed the title Prepare CMSSW_10_4_X_Patatrack for merging into CMSSW_10_4_X Prepare CMSSW_10_5_X_Patatrack for merging into CMSSW_10_5_X Jan 15, 2019
@fwyzard fwyzard added this to the CMSSW_10_5_X_Patatrack milestone Jan 15, 2019
@fwyzard fwyzard changed the title Prepare CMSSW_10_5_X_Patatrack for merging into CMSSW_10_5_X Prepare CMSSW_10_6_X_Patatrack for merging into CMSSW_10_6_X Mar 14, 2019
@fwyzard fwyzard changed the title Prepare CMSSW_10_6_X_Patatrack for merging into CMSSW_10_6_X Prepare CMSSW_11_0_X_Patatrack for merging into CMSSW_11_0_X May 21, 2019
@fwyzard fwyzard pinned this issue May 21, 2019
@fwyzard fwyzard changed the title Prepare CMSSW_11_0_X_Patatrack for merging into CMSSW_11_0_X Prepare the Patatrack branch for merging into CMSSW May 21, 2019
@fwyzard
Copy link
Author

fwyzard commented Jan 28, 2020

I think by now all issues have either been addressed, or dropped.
Further changes can be done during the upstream review process, or after the merge.

@fwyzard fwyzard closed this as completed Jan 28, 2020
@fwyzard fwyzard unpinned this issue Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants