Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fitting Code does not converge properly #18

Open
uzzielperez opened this issue Sep 27, 2020 · 0 comments
Open

Fitting Code does not converge properly #18

uzzielperez opened this issue Sep 27, 2020 · 0 comments

Comments

@uzzielperez
Copy link
Collaborator

uzzielperez commented Sep 27, 2020

While the templates are now being prepared properly, the fitting code still doesn't converge for 2017. It finishes for 2018 but the results are not expected. Need to figure out why this is happening.

The instructions for running the fitting code are here:

https://github.com/uzzielperez/diphoton-analysis/blob/ClosureTestCorrTemplates/FakeRateAnalysis/ClosureTestTemplateFits/README.md

One possible issue is that the ntuples have a finer binning and we might want to have a coarser binning for the closure test like before. We might need to find a way to merge some pt bins in the fit code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant