Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Allow customization if DismissButton in TokenGroup #2033

Open
2 tasks done
x6j8x opened this issue Mar 3, 2024 · 5 comments
Open
2 tasks done

[Feature Request]: Allow customization if DismissButton in TokenGroup #2033

x6j8x opened this issue Mar 3, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@x6j8x
Copy link

x6j8x commented Mar 3, 2024

Description

Hi,

it would be great if we would be able to customize the DismissButton icon of a TokenGroup to better communicate intend to our users.

Our use-cases revolves around the selection of multiple items out of a larger pool (30-40) of options. Using the standard Select is tedious for our users because of the missing overview and direct access.

So currently we're looking into using two TokenGroups - one for the available options and one for the selected options. First tests showed that our users are confused when having an "X" button on the items available for selection as well as on the selected ones - no matter the visual clues we provided to differentiate the two groups.

Being able to pass in an optional icon-name to be used for the DismissButton (add-plus in our case) would help mitigate this issue and to improve the user experience.

Code of Conduct

@x6j8x x6j8x added the enhancement New feature or request label Mar 3, 2024
@johannes-weber
Copy link
Member

Hi Sascha, thanks for reaching out!

Could you elaborate what you mean by - this will help me better understand the problem.

Using the standard Select is tedious for our users because of the missing overview and direct access.

You’ve mentioned the standard Select component - have you considered using the Multiselect component instead?

@x6j8x
Copy link
Author

x6j8x commented Mar 4, 2024

Hi Johannes,

yes we had a look at the multiselect component. But this is still a drop down which requires a lot of scrolling in our case just to get an overview over the options.

Having the all available options in one TokenGroup and the selected set in another - all visible and accessible at once is the thing we're looking/striving for.

@johannes-weber
Copy link
Member

It's hard to imagine how the tokens with plus icon behave in the adding/removing flow you described. Can you post a mockup or a screenshot to help us understand the problem better?

@x6j8x
Copy link
Author

x6j8x commented Mar 6, 2024

Hi Johannes,

the behaviour would be as follows:

Two TokenGroups - at the beginning the first one is filled with all available items (with "+" dismissal icon). Upon on dismissing an item from that first group, it will be "moved" (removed from the first, added to the second) to the second group (selected items, normal dismissIcon X).
When dismissing an item from the second group, it will be moved back to the first.

@jci-aws
Copy link

jci-aws commented Jun 26, 2024

Adding to this - it would be great to have an option to remove the Dismiss button from the Token entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants