Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suffix Stripping using a Regex instead of HasSuffix Function #198

Open
Scoobed opened this issue Aug 22, 2018 · 4 comments
Open

Suffix Stripping using a Regex instead of HasSuffix Function #198

Scoobed opened this issue Aug 22, 2018 · 4 comments

Comments

@Scoobed
Copy link

Scoobed commented Aug 22, 2018

Suffix Stripping is currently using strings.HasSuffix Function

The issue is in our environment as we push our applications the product that pushes our builds adds a suffix like [AppName]-new-build-XXXXXX-venerable so using the HasSuffix Function will only remove one piece. If we use a regex expression instead, we could be more dynamic in the removal.

e824aae

@shinji62
Copy link
Contributor

@Scoobed I understand but I would like to avoid to add to much transformation / regexp

Wondering what will happen for nozzle which handle 10K msg/s ? How this will impact the perf ?

Thanks

@Scoobed
Copy link
Author

Scoobed commented Aug 23, 2018

Currently working to push a bosh dev release in our test environment with the straight 5.0.0 so we test what is there. We might try a pull request with regex instead or maybe be able to flip the two to get a better picture of the performance hit of each

@shinji62
Copy link
Contributor

When you will be sure that no real impact on perf. Then I will accept the PR.

@Scoobed
Copy link
Author

Scoobed commented Aug 31, 2018

Ok, we have the Dev release with the 5.0.0 Binary running matching this release in two environments. I was having a question on how would I get my forked Binary 5.0.1 into the logsearch-for-cloudfoundry release without you needing to merge it here first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants