You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
This causes NPM to re-download and re-install wranger on each invocation of this action.
Notice how there is an NPM warning that it will need to install wrangler.
We're considering migrating from Netlify to Cloudflare Pages - to deploy the same site, nwtgck/actions-netlify takes 2 seconds while this action takes 19 seconds.
If wrangler was in-lined / cached by this action, the deployment would take much less time to finish.
The text was updated successfully, but these errors were encountered:
ari-becker
added a commit
to ari-becker/pages-action
that referenced
this issue
Feb 15, 2023
Once we have more of the Wrangler API built out we could use it as a dependency + bundle it into the action. Right now, however, we cannot.
We could theoretically use cache here, I'm not too sure it'll make a big improvement. 19 seconds is still a pretty short time.
I'll leave this open to consider though.
Given the Wrangler CLI is already an NPM package, is there any reason it doesn't export its main program to be invoked programmatically? It wouldn't increase the API surface of that package at all, but it would allow this package to import main and call it directly, at which point it would also allow this package to esbuild that package into the shipped JavaScript file. It would also resolve #74 and #75.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This action invokes
npx wrangler
via the shell:pages-action/src/index.ts
Line 37 in 0fc25c3
This causes NPM to re-download and re-install
wranger
on each invocation of this action.Notice how there is an NPM warning that it will need to install wrangler.
We're considering migrating from Netlify to Cloudflare Pages - to deploy the same site,
nwtgck/actions-netlify
takes 2 seconds while this action takes 19 seconds.If
wrangler
was in-lined / cached by this action, the deployment would take much less time to finish.The text was updated successfully, but these errors were encountered: