Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: allow different type of subnets #159

Open
cao2504 opened this issue Feb 8, 2022 · 0 comments
Open

feature request: allow different type of subnets #159

cao2504 opened this issue Feb 8, 2022 · 0 comments

Comments

@cao2504
Copy link

cao2504 commented Feb 8, 2022 •
edited
Loading

For the latestcdk v1 version, the default subnet type is set to Isolated instead of Private https://github.com/aws/aws-cdk/blob/master/packages/aws-cdk/lib/context-providers/vpcs.ts. When deploying the stack it will fail and complain about subnets are empty.
Can we have a flexibility to choose which type of subnet to be passed in?

cdk-constructs/packages/cdk-blue-green-container-deployment/src/ecs-service.ts

Line 138 in 28be208

Subnets: vpc.privateSubnets.map((sn) => sn.subnetId),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cao2504