-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network configuration (v1) does not work with v1.1.5 and newer #147
Comments
Hello @derSchweiger, I see in the logs a Thanks and please let me know how I can reproduce the issue if you use a custom metadata service. |
Hi @ader1990, thank you! You are right, we had to implement a minor change because the configuration of the Administrator password didn't work properly:
To load our modified NoCloudConfigDriveService service instead of the default one, we have slightly adapted the cloudbase-init[-unattend].conf:
The rest (including the network configuration) stays the same. In my opinion, this should not be the cause of the problem mentioned? Appreciate your help! |
I think this commit needs to be investigated: f0fe66b Can you please provide the full meta_data file from your config drive, so that I can try to reproduce the issue? |
Yes, it also fits in terms of time. Cloudbase-Init v1.1.5dev11 (in which the network config works) has been released before this commit. Metadata as requested (needed to remove some unreadable chars):
Please let me know if you need any additional information. |
Hello, I have created a patch here with a possible fix: https://review.opendev.org/c/x/cloudbase-init/+/922464 |
If you could compile a MSI file for me that would be great! |
This Github Action should create a test installer using the branch https://github.com/ader1990/cloudbase-init-1/tree/add_nocloud_network_tests https://github.com/ader1990/cloudbase-init-installer-1/actions/runs/9613069308/job/26515021223 The installer can be found in the Artifacts tab as a zipped artifact. |
Cool, appreciated! Our automation is already creating a new build with this version of cloudbase-init. I'll let you know as soon as my tests are completed. |
@ader1990 while loading and configuring the unattend phase I receive the following error:
Therefore, the machine is hanging in a sysprep loop and cannot be started normally. Shouldn't this module be included in the MSI package or do I've to prep it manually? |
Hello, this might be an issue with how the Github Actions created the installer - as it used a Python embedded version. The Github actions are usually more flaky as well. I started a new build here with the official Python installer contents version: https://github.com/ader1990/cloudbase-init-installer-1/actions/runs/9617044573. The fastest way to test this would be to just drop in replace the nocloud service python file using the change from https://review.opendev.org/c/x/cloudbase-init/+/922464 or ader1990@90c0546, delete the registry folder HKLM:\SOFTWARE\Cloudbase Solutions\Cloudbase-Init and rerun cloudbase-init on the initial env. |
Option #2 didn't do the trick for me. VM started but I received the same error message in the cloudbase-init.log file and the service didn't run successfully. |
The patch https://review.opendev.org/c/x/cloudbase-init/+/922464 was tested with https://github.com/cloudbase/cloudbase-init-test-resources/pull/14/files#diff-4708310a57ee945744728723c092dd3aeca2354e84070b51e7d6254c389309f0 network-config and it worked correctly when using the Github Runners too. |
Yeah, error might be on my side, but nevermind, your new build works just fine! Network config gets set properly and the other stuff works too. Just a quick log output:
I haven't tested the userdata plugin (to inject a PowerShell script) yet but afaik there was no change so it should work. Just another quick question: do you summarise all the changes between the different versions in a changelog or something like that? Haven't found anything. |
Hello, we are planning to move to GitHub shortly and we will also have a good changelog history in the release. Also, we are adding Github Actions functional testing to properly cover the network static configuration https://github.com/cloudbase/cloudbase-init-test-resources/pull/14/files. I will keep you posted once the new beta MSI gets built and also when a new release is made. Thanks alot, |
Hello @derSchweiger, the fix has been merged and you can check the beta build installer: https://www.cloudbase.it/downloads/CloudbaseInitSetup_x64.msi. We are planning a new stable release soon, after more functional tests are added to the github actions. @laozc -> this commit f0fe66b added a regression in the NoCloud metadata service and has been fixed already. Can you please check if the fixed MSI (latest beta build https://www.cloudbase.it/downloads/CloudbaseInitSetup_x64.msi) still works as expected with the VmwareGuest metadata service? Thank you all. |
Have tested the new beta version (1.1.6dev20) and it works as expected. Network configuration was successfully read and set. |
Sure. Let me verify the change with VMware Guest metadata service. |
@ader1990 The beta version (1.1.6dev20) works with both V1 and V2 network config format with VMware DataSource. |
Thanks @laozc! |
Hi,
it seems that since the release of stable Cloudbase-Init v1.1.5, the network configuration can no longer be set properly. There is no error message, instead cloudbase-init assumes that we are not injecting a network configuration:
cloudbaseinit.metadata.services.nocloudservice [-] Network configuration is empty
Injected network config:
cloudbase-init logs:
Same issue on the newest unstable build v.1.1.6dev13. The last build I'm aware of where the injection of the network configuration works is 1.1.5dev11. Something has changed since then.
If you need any further information, please let me know.
The text was updated successfully, but these errors were encountered: