-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging dissapears in Calva in versions from 2.0.437 with cidr-nrepl 0.47.1 - possible cause is logjam #18
Comments
Logjam is an opt-in feature related to object logging (as opposed to capturing text streams) that most likely isn't used by Calva at all. You probably should be looking at https://github.com/clojure-emacs/cider-nrepl/blob/31a3d02e13ae1daff0637330c27d83f5943a8486/src/cider/nrepl/middleware/out.clj instead
We try hard to keep backwards compatibility, that's all I can say. Cheers - V |
@ieugen worth noting, cider-nrepl is a composition of middleware. One can remove the |
Let's also cc @PEZ here, as might need more context about recent changes made in Calva that might be related to this. |
I did notice that Calva used an ancient version of |
Thank you for looking at this as well @bbatsov . I will try to make a reproducer repo. I tried latest Calva with a smaller project that used tools.looging and slf4j-simple and it worked ok.
|
👋 I should have testet much more before I upgraded. But I ran with the newer version for long and everything seemed to work. But I am not every user, so this part I missed. I am not all that clear about what “this part” even is, tbh. Not sure if Calva is using the |
Thanks much for the useful info! Yes, out-subscribe is part of out. If you've performed Which means that (Then again, you indicate that you are subscribing - I assume that you make good use of these subscriptions?) We might need a repro to proceed. |
So I tried to create a repro but did not maanged to do that yet. I have created a project with a deps.edn
And a src/user.clj
And this works, Will try to figure out why Calva does not work in our project . |
Kudos for working on the repro. I reckon that you should replicate how Perhaps what's happening is that it starts working (i.e. creating an |
Did not manage to reproduce yet but seems to be something that happens in our code. I started an nrepl server in another project using the classpath computed for :dev alias in our project - 45kb of text :) . Can you please help me check I am doing things ritght?
Would be nice to load CP from file. |
For being extra sure, you can copy the exact classpath from
|
Feel free to continue the conversation. |
Hello,
This issue is mostly to discuss options.
We are using Calva and we noticed logs are no longer shown from a day or two.
We are using tools.logging facade with https://github.com/amperity/dialog as a SLF4j implementation.
We are directing all logging capture to slf4j.
It seems that logjam tries to do the same and this creates an issue where no logging is shown.
We got the recommendation to use an older version of cider but IMO that will work only for a limited amount of time.
How many years can we use an older version of cidr-nrepl before we are forced to upgrade ?!
We have traced this to a Calva upgrade https://github.com/BetterThanTomorrow/calva/blob/published/CHANGELOG.md#20437---2024-04-11
See discussion https://clojurians.slack.com/archives/CBE668G4R/p1712950069143409
I am still investigating the issue - we might be able to remove a dependency and make things work but I have an un-easy fealing about logjam taking over logging from the app.
IMO each app should be in control of it's logging.
This might be related to #12 as well ?!
The text was updated successfully, but these errors were encountered: