-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cljs-pending never changes to cljs despite REPL working OK. source buffers never recognise the pending REPL though #3246
Comments
I can confirm this behavior. When I make sure to link the right REPL with the right buffer and I evaluate |
Hmm, that's weird. This is set automatically by |
where is the nREPL message log please? |
And that's one of the related issues I mentioned earlier #2456 |
I have to investigate this at work in a different environment where I had that issue. |
sorry for the delay, I attached the nrepl-messages buffer content now. does it say anything useful? |
I was facing the same problem using a shadow-cljs template setup from the Kit project. But when I add the cider-nrepl dependency (and shadow-cljs will automatically use the middleware), every thing turns ok. |
@lotuc - I have always had [cider/cider-nrepl "0.28.7"] in dependencies, in shadow-cljs.edn. It did not help |
This got fixed with either of these: ...I verified so by both:
These fixes are available in CIDER master, and in the 1.8.0 release we are working towards. Cheers - V |
yes, it is working now, thanks :) |
Happy to read that! 🍻 |
Expected behavior
when cljs REPL starts, it changes from pending-cljs in REPL buffer status line to cljs, and clojurescript source buffers get associated with this REPL.
Actual behavior
cljs stays in pending-cljs state and source buffers show cider[not connected]. C-z (go to repl), M-. (go to source), evaluating in source does not work. It says there is no REPL.
Steps to reproduce the problem
Minimal setup:
deps.edn
{}
shadow-cljs.edn
{:source-paths ["src"]}
src/cljs.cljs
Then open src/cljs.cljs and cider-jack-in-cljs. I will get the REPL, browser tab is started, and I can evaluate things in REPL, but with the issue described at the top (pending-cljs, source buffers don't see the REPL).
I end up in the same situation when using cider-connect-cljs instead of cider-jack-in-cljs, or when I use figwheel-main instead of shadow-cljs.
Workaround:
I changed line 318 in cider-connection.el, in function
cider--connected-handler
CIDER version information
CIDER 1.5.0 (Strasbourg), nREPL 1.0.0
Clojure 1.11.1, Java 18.0.1
Emacs version
Emacs 28.1
Operating system
Ubuntu 22.04.1 LTS
The text was updated successfully, but these errors were encountered: