The chairs requested notifications sent twice a week about new comments, and judgements on applications by other chairs. To reduce the number of emails we're sending the to the chairs we decided to include approval reminders with these emails as well.
To accomplish twice-weekly digests of submission notifications the GPM creates DigestibleNotifications each time a comment is created, updated, deleted, or approved, and each time a judgement is created, updated, or deleted.
Notifications are only sent to users with ep-applications-approve and ep-applications-comment system permissions. Notifications about comment and judgement activity are not sent to the creator of the comment or judgement.
Twice a week approval reminder notifications are generated and SendSubmissionNotificationsDigest is run to aggregate the digestible notifications and send them as a single email.
While automated tests exist to test the units and aspects of their integration, it seemed prudent to manually test a sequence of actions taken by different users and ensure the expected notifications are sent.
This script describes a sequence of actions and the expected notification outcomes.
-
Submit VCEP application
-
Comment as Courtney & Send to chairs.
- Expect email sent to each chair about application
-
Comment as Sharon.
-
Reply as Courtney.
-
Generate ApprovalReminders and send digest
- Expect email to all chairs:
- Jonathan: approval reminder, comment
- Heidi: approval reminder, comment
- Sharon: approval reminder
- Expect email to all chairs:
-
Comment as Jonathan
-
Comment as Heidi
-
Comment as Danielle
-
Judgement as Sharon
-
Submit & approve GCEP application
- Expect email sent to each chair about application
-
Comment as Jonathan
-
Generate ApprovalReminders and send digest
- Expect email to all chairs:
- Jonathan: 2 approval reminders, 2 comments, 1 judgement
- Heidi: 2 approval reminders, 2 comments, 1 judgment
- Sharon: 1 approval reminder, 3 comments (2 groups)
- Expect email to all chairs: