New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run coveralls only in merge commit #115

Open

item4 opened this issue Oct 3, 2015 · 1 comment

Labels

suggestion (discussion)

Member

item4 commented Oct 3, 2015

In PR, No one can access secure environment variables. So some tests will be passed and coverage must be decreased.

I think it is insain. :(

I want to fix to run coveralls only in merge commit.

item4 added the suggestion (discussion) label

Contributor

miaekim commented Oct 3, 2015

I don't agree with that. what if we could not check running? we need to check our pr before merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment