Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenForHost returns string "oauth_token" as source when config is read from file #94

Open
mislav opened this issue Jan 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@mislav
Copy link
Contributor

mislav commented Jan 10, 2023

TokenForHost source return value should be a value like GH_TOKEN or GITHUB_TOKEN when the token comes from an environment variable, or a file path (e.g. /path/to/hosts.yml) when the value comes from a file. However, a static string oauth_token is returned instead of a file name:

return token, oauthToken

Since oauth_token source is not useful to find out where a value comes from, printing the file name would be better.

Ref. #44

@samcoe samcoe added the enhancement New feature or request label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants