Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick edit window is read-only #956

Open
capfei opened this issue Mar 1, 2022 · 3 comments
Open

Quick edit window is read-only #956

capfei opened this issue Mar 1, 2022 · 3 comments

Comments

@capfei
Copy link
Member

capfei commented Mar 1, 2022

The quick edit button on the main page and workspace does not let you edit any of the fields. You cannot type anything in the license and source location fields. The "Release" calendar lets you select a date but does not update the date in the date field.

image

@ariel11
Copy link

ariel11 commented Mar 11, 2022

This is a significant pain point because if we want to curate let's say 10 package versions of a particular package, we use the above feature to add that data for those 10 versions and then hit "Contribute" and submit that data in one PR. However, as stated above, the pop-up window to edit is "read only." So now we can only curate one package version at a time per "Contribute" form.

qtomlinson added a commit to qtomlinson/website that referenced this issue Jun 10, 2022
-add handleSaveEdit
-display the changes correctly with original values in tool tip

Task: clearlydefined#956
qtomlinson added a commit to qtomlinson/website that referenced this issue Jun 10, 2022
-Integrate SourceLocationPicker in QuickEditModel
--also adjust styling so SourceLocationPicker looks ok inside QuickEditModel
-Support saving source location edit
-Add syncing activeProvider from props to handle display of non github source location in QuickEditModel

Task: clearlydefined#956
qtomlinson added a commit to qtomlinson/website that referenced this issue Jun 10, 2022
-add handleSaveEdit
-display the changes correctly with original values in tool tip

Task: clearlydefined#956
@bduranc
Copy link

bduranc commented Jan 9, 2023

I can confirm these quick edit fields do appear modifiable now. The data changes appear to stage, and I confirmed the PR could be created for a component using the quick edit dialog. clearlydefined/curated-data#23060

@bduranc
Copy link

bduranc commented Jan 13, 2023

@capfei is this another one we can close? Pls let me know if there is anything else I can do to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants