Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix random bugs #7

Open
3 tasks done
claucookie opened this issue Jan 24, 2020 · 0 comments
Open
3 tasks done

Fix random bugs #7

claucookie opened this issue Jan 24, 2020 · 0 comments
Assignees
@claucookie
Labels
bug Something isn't working
Milestone
Coding Test

Comments

@claucookie
Copy link
Owner

claucookie commented Jan 24, 2020 •
edited
Loading

  • At the moment the Mainviewmodel is making the network call when the MainActivity changes orientation.

  • Somehow, Moshi does not parse neither the nested class "owner" nor "stargazers_count".

  • Readme file does not get loaded due to owner being null
@claucookie claucookie added the bug Something isn't working label Jan 24, 2020
@claucookie claucookie added this to the Coding Test milestone Jan 24, 2020
@claucookie claucookie self-assigned this Jan 24, 2020
@claucookie claucookie mentioned this issue Jan 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claucookie claucookie

Labels
bug Something isn't working
Projects
None yet
Milestone
Coding Test
Development

No branches or pull requests
1 participant
@claucookie