Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reseach CSS de-duplication on multiple imports #8400

Closed
jodator opened this issue Nov 2, 2020 · 2 comments
Closed

Reseach CSS de-duplication on multiple imports #8400

jodator opened this issue Nov 2, 2020 · 2 comments
Labels
domain:dx This issue reports a developer experience problem or possible improvement. domain:extending-builds type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 39 (v25...

Comments

@jodator
Copy link
Contributor

jodator commented Nov 2, 2020 •
edited
Loading

Deal with CSS de-duplication when enabling adding plugins to a build #8395.
@jodator jodator added the type:task This issue reports a chore (non-production change) and other types of "todos". label Nov 2, 2020
This was referenced Nov 2, 2020
Closed
Closed
Closed
Closed
@jodator jodator added this to the iteration 38 milestone Nov 2, 2020
@jodator jodator added domain:dx This issue reports a developer experience problem or possible improvement. squad:dx labels Nov 2, 2020
@jodator jodator modified the milestones: iteration 38, backlog Nov 23, 2020
@jodator
Copy link
Contributor Author

jodator commented Dec 4, 2020

AFAICS there's no problem with our current theme approach and using DLLs. As long there is no code duplication I can't see any CSS duplication. If there's code duplication, the editor will not start 🤷‍♂️

@jodator jodator modified the milestones: backlog, iteration 39 Dec 10, 2020
@jodator
Copy link
Contributor Author

jodator commented Dec 10, 2020

The outcome of this is that we don't see any CSS duplication when using DLL builds. 🎉.

@jodator jodator closed this as completed Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:dx This issue reports a developer experience problem or possible improvement. domain:extending-builds type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 39 (v25.0.0)
Development

No branches or pull requests
2 participants
@Reinmar @jodator