Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Watchdog and Context on Editor class and update integrations. #13852

Closed
Reinmar opened this issue Apr 11, 2023 · 5 comments · Fixed by #16415 · May be fixed by Klantinteractie-Servicesysteem/KISS-frontend#929
Closed
Labels
squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 11, 2023

Notes:

@Reinmar Reinmar added type:task This issue reports a chore (non-production change) and other types of "todos". squad:core Issue to be handled by the Core team. labels Apr 11, 2023
@niegowski
Copy link
Contributor

In the react integration it was skipped because the code there is using inference for the editor type <TEditor extends Editor> and since the Editor class does not have those static fields (Context, EditorWatchdog, ContextWatchdog) we can't access them. Those fields are only on the EditorClassic level.

We decided we don't want the core package to depend on the watchdog package. I think we should revisit this decision.

@Reinmar
Copy link
Member Author

Reinmar commented Apr 12, 2023

How was that supposed to work in Angular integration then? Or it was something that we completely missed?

@niegowski
Copy link
Contributor

Or it was something that we completely missed?

I think this is the case.

@Witoso
Copy link
Member

Witoso commented Apr 26, 2023

Scope:

  • Add ckeditor5-watchdog to the “Framework” layer and make the base Editor expose these
    • Simpler option.
    • Risk: circular dependency on types between the editor and watchdog interfaces.
  • Update integrations.
    • This time let’s also update the integrations to verify that it all works together.

@Witoso Witoso changed the title ckeditor5-watchdog is still a dependency of ckedito5-angular Expose Watchdog and Context on Editor class and update integrations. Apr 26, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Apr 26, 2023
@CKEditorBot CKEditorBot removed the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jun 12, 2023
@Witoso
Copy link
Member

Witoso commented Aug 16, 2023

Scope:

  • Expose Context, EditorWatchdog, and ContextWatchdog as static editor properties of the base Editor class.
  • Remove Context, EditorWatchdog, and ContextWatchdog from editor implementations (e.g., ClassicEditor).
    • keep the tests so we have an additional layer of checks.
  • Update docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
4 participants