Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin toolbar icon is blurry when used in CKEditor #17

Open
AnnaTomanek opened this issue Jun 14, 2023 · 0 comments
Open

Plugin toolbar icon is blurry when used in CKEditor #17

AnnaTomanek opened this issue Jun 14, 2023 · 0 comments

Comments

@AnnaTomanek
Copy link

The icon was designed for 16x16px due to GitHub UI: https://github.com/ckeditor/ckeditor5-mermaid/blob/master/theme/icons/insert.svg?short_path=b87e06b#L1

But since CKEditor 5 uses 20px icons, it looks blurry in our own Mermaid integration example in the docs on non-Retina screens:
Screenshot 2023-06-14 at 08 40 29

Looks OK for Retina:
Screenshot 2023-06-14 at 08 42 55

As per @oleq's comment:

If you use 1px strokes in 16px, you get 1.25px in 20px. If you use 2px strokes in 16px you get 2.5px in 20px. There’s no way to get sharp integers in both sizes. So there will always be blur in some case unless we provide two dedicated icon sets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant