Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command names should be simplified (no need for *Command postfix) #15

Open
mlewand opened this issue Nov 21, 2022 · 0 comments
Open

Command names should be simplified (no need for *Command postfix) #15

mlewand opened this issue Nov 21, 2022 · 0 comments
Labels
intro

Comments

@mlewand
Copy link
Contributor

mlewand commented Nov 21, 2022

We have following commands:

  • mermaidPreviewCommand
  • mermaidSplitViewCommand
  • mermaidSourceViewCommand
  • insertMermaidCommand

The "Command" postfix is redundant and should be removed. After all they are in commands collection so it's very likely it won't be a button or anything else 😅
@mlewand mlewand added the intro label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
intro
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mlewand