Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase pool size of DrawableStore #2880

Closed
kamelzarandah opened this issue Oct 25, 2024 · 21 comments
Closed

increase pool size of DrawableStore #2880

kamelzarandah opened this issue Oct 25, 2024 · 21 comments

Comments

@kamelzarandah
Copy link

What happened?

with the increase of streamed files and new maps being added in redm we face an issue of reaching DrawableStore max pool size which results in an instant crash upon loading into the server, we would like to request the ability to increase that pool size so that we can continue to add new maps
image
image

Expected result

ability to add more ydr files without crahsing

Reproduction steps

i got the crash when i reached approx 1000+ ydrs

Importancy

Crash

Area(s)

FXServer

Specific version(s)

redm/ windows 10573

Additional information

No response

@kamelzarandah kamelzarandah added bug triage Needs a preliminary assessment to determine the urgency and required action labels Oct 25, 2024
@github-actions github-actions bot added the crash label Oct 25, 2024
@Masterspooni
Copy link

I support that.

@Cleetus777
Copy link

Supported, this needs to happen

@macabreredm
Copy link

100 percent this needs to happen redm is evolving everyday and something like this would be great

@AvocadoOutlaw
Copy link

Please do this! We want to fully open the map as much as possible to add new places for players to explore, call home, or own a new business venture! FiveM I know can increase their own Pool Size limits but RedM server owners don't get this advantage. Once we reach this limit we have to be careful on what we pick and choose to add.

All custom items and new mappings we have to miss out on completely or sacrifice something in its place. This is a issue I had no clue about until I reached this limit. I fully support this!

@VarusXX
Copy link

VarusXX commented Oct 25, 2024

I support that. We need bigger pools and how to activate this

@S-H-Development
Copy link

This will become essential at one point or another, I think the time may be now. +1!

@AvarianKnight
Copy link
Contributor

While its understandable to want the pool size increase, having a bunch of people spam the issue isn't the way to do it.

@roancrous
Copy link

I support this too

@BonnieAmarie
Copy link

I fully support this!

@Siddwell740
Copy link

Definitely would like to see this happen

@NOIACAST-br
Copy link

Eu apoio

@ook3D
Copy link
Contributor

ook3D commented Oct 25, 2024

i love when people spam their useless opinion on issues blocking actual constructive discussion!

@ook3D
Copy link
Contributor

ook3D commented Oct 26, 2024

I fully support this!

Oh BonnieAmarie supports this? Quick everyone to work! Thank you for your ever so valuable input.

@kamelzarandah
Copy link
Author

MaxDoorExtensions value="320"
if possible can we also get this pool size, as of right now, exceeding this one also causes an instant crash
RDR2_b1491.exe!?Entities_Create@fwMapDataContents@rage@@s?_PPAVfwMapData@rage@@PAVfwMapDataContents@Entities_Create@@h@Z (0x10a)

Door extensions crash (if you have to many Door extensions in ymap or ytyp Files)

something like this happens when you have many big apartment buildings for example in saint denis where all the big buildings are next to each other

@Fixitfy
Copy link

Fixitfy commented Oct 26, 2024

I support. this is a big problem

@NiXyos
Copy link

NiXyos commented Oct 26, 2024

I support, today we need to develop our game boards with more and more content.

@ook3D
Copy link
Contributor

ook3D commented Oct 26, 2024

I support, today we need to develop our game boards with more and more content.

What are you even talking about, game boards? No one cares if you support this or not.

@BlackLegion23
Copy link

Support 100%

@Quiteck1983
Copy link

Support this, we need it!

@iSn4x
Copy link

iSn4x commented Oct 27, 2024

Yes, pls make changing pool sizes possible.

@prikolium-cfx
Copy link
Contributor

Thanks for your feedback. We've added DrawableStore to our new system of pool resizing.
You can find more information on how to use it here: citizenfx/fivem-docs@fd7ac6a#diff-331e99259d1395f290e695c1c52cfb483254b82a1a1534aadcaabc08ad0d8e5dR408
Currently we limited DrawableStore to additional 50k items. Let us know when/if you need more.

@github-actions github-actions bot removed the triage Needs a preliminary assessment to determine the urgency and required action label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests